Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v21.2.0 release proposal #50681

Merged
merged 144 commits into from
Nov 14, 2023
Merged

v21.2.0 release proposal #50681

merged 144 commits into from
Nov 14, 2023

Conversation

targos
Copy link
Member

@targos targos commented Nov 12, 2023 •
edited
Loading

2023-11-14, Version 21.2.0 (Current), @targos

Notable Changes

  • [e25c65ee2f] - doc: add MrJithil to collaborators (Jithil P Ponnan) #50666
  • [f2366573f9] - doc: add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
  • [eac9cc5fcb] - (SEMVER-MINOR) esm: add import.meta.dirname and import.meta.filename (James Sumners) #48740
  • [7e151114b1] - fs: add stacktrace to fs/promises (翠 / green) #49849
  • [6dbb280733] - (SEMVER-MINOR) lib: add --no-experimental-global-navigator CLI flag (Antoine du Hamel) #50562
  • [03c730b931] - (SEMVER-MINOR) lib: add navigator.language & navigator.languages (Aras Abbasi) #50303
  • [f932f4c518] - (SEMVER-MINOR) lib: add navigator.platform (Aras Abbasi) #50385
  • [91f37d1dc3] - (SEMVER-MINOR) stream: add support for deflate-raw format to webstreams compression (Damian Krzeminski) #50097
  • [65850a67c7] - stream: use Array for Readable buffer (Robert Nagy) #50341
  • [e433fa54b7] - stream: optimize creation (Robert Nagy) #50337
  • [c9b92bba58] - (SEMVER-MINOR) test_runner: adds built in lcov reporter (Phil Nash) #50018
  • [f6c496563e] - (SEMVER-MINOR) test_runner: add Date to the supported mock APIs (Lucas Santos) #48638
  • [05e8b6ef20] - (SEMVER-MINOR) test_runner, cli: add --test-timeout flag (Shubham Pandey) #50443

Commits

khaosdoctor and others added 30 commits November 11, 2023 20:37
@khaosdoctor @targos
test_runner: add Date to the supported mock APIs
f6c4965 
signed-off-by: Lucas Santos <[email protected]>
PR-URL: #48638
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ronag @targos
stream: avoid getter for defaultEncoding
766bd9c 
PR-URL: #50203
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@H4ad @targos
perf_hooks: reduce overhead of createHistogram
905ca00 
PR-URL: #50074
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@H4ad @targos
test: avoid v8 deadcode on performance function
ad31641 
PR-URL: #50074
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@RafaelGSS @targos
meta: mention other notable changes section
e008336 
PR-URL: #50309
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
@nodejs-github-bot @targos
tools: update lint-md-dependencies
bd46348 
- @rollup/[email protected]
- @rollup/[email protected]
- [email protected]

PR-URL: #50190
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MrJithil @targos
src: add commit hash shorthand in zlib version
541bdf1 
src: add commit hash shorthand in zlib version
PR-URL: #50158
Fixes: #50139
Reviewed-By: Marco Ippolito <[email protected]>
@anonrig @targos
fs: do not throw error on cpSync internals
3e7226a 
PR-URL: #50185
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95 @targos
test: ensure never settling promises are detected
31cd05c 
PR-URL: #50318
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aki0501 @targos
benchmark: move permission-fs-read to permission-processhas-fs-read
800206b 
PR-URL: #49770
Reviewed-By: Rafael Gonzaga <[email protected]>
@nodejs-github-bot @targos
deps: update googletest to 116b7e5
d6f49c7 
PR-URL: #50324
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@nodejs-github-bot @targos
tools: update eslint to 8.52.0
5ccdda4 
PR-URL: #50326
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@mhdawson @targos
benchmark: skip test-benchmark-os on IBMi
2006b57 
- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@rluvaton @targos
benchmark: add more cases to Readable.from
c4b6e1e 
PR-URL: #50351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@ronag @targos
stream: refactor writable _write
f56ae67 
PR-URL: #50198
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@nodejs-github-bot @targos
deps: update llhttp to 9.1.3
62515e1 
PR-URL: #50080
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@lemire @targos
src: use find instead of char-by-char in FromFilePath()
f1d79b3 
PR-URL: #50288
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@zcbenz @targos
build: fix building when there is only python3
54ebfc1 
PR-URL: #48462
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@mika-fischer @targos
test_runner: test return value of mocked promisified timers
e2c3b01 
PR-URL: #50331
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ronag @targos
stream: optimize creation
e433fa5 
Refs: nodejs/performance#79

PR-URL: #50337
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@bryce-seefieldt @targos
doc: fix TOC in releases.md
d9f92bc 
Fixes: #50368
PR-URL: #50372
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@philnash @targos
test_runner: adds built in lcov reporter
c9b92bb 
Fixes #49626

PR-URL: #50018
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@ronag @targos
stream: use Array for Readable buffer
65850a6 
PR-URL: #50341
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos
doc: add Ethan-Arrowood as a collaborator
f236657 
PR-URL: #50393
Fixes: #50170
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@joyeecheung @targos
src: implement structuredClone in native
5b453d4 
Simplify the implementation by implementing it directly in C++.
This improves performance and also makes structuredClone supported
in custom snapshots.

PR-URL: #50330
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@Uzlopak @targos
benchmark: add benchmarks for encodings
3f37ed9 
PR-URL: #50348
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95 @targos
tools: run coverage CI only on relevant files
f210915 
PR-URL: #50349
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
@ronag @targos
stream: readable use bitmap accessors
586ec48 
PR-URL: #50350
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
@mhdawson @targos
doc: add information about Node-API versions >=9
d62e812 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <[email protected]>
@lukealbao @targos
test: v8: Add test-linux-perf-logger test suite
ab9cad8 
PR-URL: #50352
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
MrJithil and others added 13 commits November 14, 2023 09:18
@MrJithil @targos
lib: fix assert shows diff messages in ESM and CJS
363bc46 
This PR addresses an issue which was caused by the design in
the ESM loader.
The ESM loader was modifying the file path and replacing the 'file'
property with the file proto in the stack trace.
This, in turn, led to unhandled exceptions when the assert module
attempted to open the file to display erroneous code.
The changes in this PR resolve this issue by handling the file path
correctly, ensuring that the remaining message formatting code can
execute as expected.

PR-URL: #50634
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 @targos
meta: fix spacing in collaborator list
49cce76 
PR-URL: #50641
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@WillLiang918 @targos
test: replace forEach() with for ... of in test-readline-keys.js
e978fd4 
PR-URL: #50604
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bliakher @targos
test: replace forEach() with for .. of
b701567 
PR-URL: #50605
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MrJithil @targos
lib: remove deprecated string methods
ed293fc 
PR-URL: #50592
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@dependabot @targos
meta: bump ossf/scorecard-action from 2.2.0 to 2.3.1
4bf9cff 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.2.0 to 2.3.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@08b4669...0864cf1)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #50509
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@dependabot @targos
meta: bump step-security/harden-runner from 2.5.1 to 2.6.0
4e83036 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.5.1 to 2.6.0.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@8ca2b8b...1b05615)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #50512
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@dependabot @targos
meta: bump github/codeql-action from 2.21.9 to 2.22.5
dedfb5a 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.9 to 2.22.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@ddccb87...74483a3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #50513
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Uzlopak @targos
errors: improve hideStackFrames
14e3675 
PR-URL: #49990
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@yedlosh @targos
test: use destructuring for accessing setting values
8be718a 
PR-URL: #50609
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@UlisesGascon @targos
tools: add macOS notarization stapler
5fcd67a 
PR-URL: #50625
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@panva @targos
meta: add web-standards as WPTs owner
9e7131f 
PR-URL: #50636
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos
2023-11-14, Version 21.2.0 (Current)
13b266f 
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib:
  * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
  * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #50681
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@targos
Copy link
Member Author

targos commented Nov 14, 2023

Optimistic release build: https://ci-release.nodejs.org/job/iojs+release/9768/

@targos
Copy link
Member Author

targos commented Nov 14, 2023

@AlttiRi it wasn't merged so I can't include it in a release.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55635/

@targos targos merged commit 13b266f into v21.x Nov 14, 2023
47 of 50 checks passed
@targos targos deleted the v21.2.0-proposal branch November 14, 2023 17:59
targos added a commit that referenced this pull request Nov 14, 2023
@targos
Working on v21.2.1
ae93ed2 
PR-URL: #50681
targos added a commit that referenced this pull request Nov 14, 2023
@targos
2023-11-14, Version 21.2.0 (Current)
02db7fc 
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib:
  * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
  * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #50681
@targos targos mentioned this pull request Nov 14, 2023
Merged
targos added a commit to targos/nodejs.org that referenced this pull request Nov 14, 2023
@targos
Blog: v21.2.0 release post
beae062 
Refs: nodejs/node#50681
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Nov 14, 2023
@targos
Blog: v21.2.0 release post (#6117)
0bd02aa 
Refs: nodejs/node#50681
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Nov 14, 2023
@targos
Blog: v21.2.0 release post (#6117)
b32db7f 
Refs: nodejs/node#50681
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Open
26 tasks
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@targos @martenrichter
2023-11-14, Version 21.2.0 (Current)
cb27942 
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) nodejs#50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) nodejs#50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) nodejs#48740
fs:
  * add stacktrace to fs/promises (翠 / green) nodejs#49849
lib:
  * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) nodejs#50562
  * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) nodejs#50303
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) nodejs#50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) nodejs#50097
  * use Array for Readable buffer (Robert Nagy) nodejs#50341
  * optimize creation (Robert Nagy) nodejs#50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) nodejs#50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) nodejs#48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) nodejs#50443

PR-URL: nodejs#50681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.